fix: init with config chain-id #9762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9762 +/- ##
==========================================
- Coverage 63.47% 63.31% -0.16%
==========================================
Files 566 563 -3
Lines 52794 52729 -65
==========================================
- Hits 33513 33388 -125
- Misses 17378 17435 +57
- Partials 1903 1906 +3
|
ryanchristo
force-pushed
the
ryan/fix-init-chain-id
branch
from
3535b9a
to
41d3039
Compare
|
Visit https://dashboard.github.orijtech.com?pr=9762&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
alexanderbez
approved these changes
Jul 26, 2021
x/genutil/client/cli/init.go
Outdated
Comment on lines
82
to
88
| chainID, _ := cmd.Flags().GetString(flags.FlagChainID) | ||
| if chainID == "" { | ||
| chainID = fmt.Sprintf("test-chain-%v", tmrand.Str(6)) | ||
| if clientCtx.ChainID == "" { | ||
| chainID = fmt.Sprintf("test-chain-%v", tmrand.Str(6)) | ||
| } else { | ||
| chainID = clientCtx.ChainID | ||
| } |
There was a problem hiding this comment.
nit: this could be cleaned up with just a single switch clause.
switch {
case chainID != "":
case clientCtx.ChainID != ""
default:
}
ryanchristo
added
the
A:automerge
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #9604, Ref: #9644
The
initcommand uses thechain-idfrom the client config if--chain-idis not provided.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change