Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file keyring fails to add/import/export keys when input is not stdin (fix #9566) (backport #9821) #9880

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: file keyring fails to add/import/export keys when input is not stdin (fix #9566) (backport #9821) #9880

merged 2 commits into from
Aug 10, 2021

Commits on Aug 9, 2021

  1. fix: file keyring fails to add/import/export keys when input is not s… 

    …tdin (fix #9566) (#9821)

## Description

Add a test case to reproduce the issue described in #9566. The test currently fails, and I've pointed some possible solutions over #9566 (comment). But I feel this needs more works in order to provide a more robust solution. I'll keep poking at better options, but taking any pointers if anyone has ideas.

(cherry picked from commit f479b51)

# Conflicts:
#	client/keys/add.go
#	client/keys/add_test.go
#	client/keys/export_test.go
    @daeMOn63
    daeMOn63 authored and mergify-bot committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    f6ad78f View commit details
    Browse the repository at this point in the history

  2. fix: merge conflict backporting pr-9821 (#9888)

    @daeMOn63
    daeMOn63 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    30e4471 View commit details
    Browse the repository at this point in the history