This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
bump Cosmos SDK version to v0.38.2 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
changed the base branch from
fedekunze/181-update-module-structure
to
development
fedekunze
commented
Mar 11, 2020
austinabell
suggested changes
Mar 11, 2020
* evm: move Begin and EndBlock to abci.go * evm: use expected keeper interfaces * app: use EthermintApp for integration and unit test setup * evm: remove count type; update codec * go mod verify * evm: rename msgs for consistency * evm: events * minor cleanup * lint * ante: update tests * changelog * nolint
…ekunze/177-bump-sdk-version
…ekunze/177-bump-sdk-version
fedekunze
commented
Apr 22, 2020
| // insert the state object into the live set | ||
| so := newStateObject(csdb, acc) | ||
| so := newStateObject(csdb, acc, balance.Amount) |
There was a problem hiding this comment.
This is the source of the bug. Every time the state was retrieved it was being initialized with 0 balance. @ColinSchwarz @austinabell @noot @austinabell
thomasmodeneis
approved these changes
Apr 22, 2020
austinabell
reviewed
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #177
Updates SDK to commit
7f78e61b93a5onmasterTargeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: