Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

types: unmarshal account from hex address #504

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

fedekunze
Copy link
Contributor

addition to #502

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #504 into development will increase coverage by 0.21%.
The diff coverage is 96.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #504      +/-   ##
===============================================
+ Coverage        71.73%   71.94%   +0.21%     
===============================================
  Files               41       41              
  Lines             2685     2709      +24     
===============================================
+ Hits              1926     1949      +23     
- Misses             618      619       +1     
  Partials           141      141              
Impacted Files Coverage Δ
types/account.go 70.40% <96.00%> (+8.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1505ba8...06cdb5e. Read the comment docs.

@fedekunze fedekunze marked this pull request as ready for review September 8, 2020 15:45
@fedekunze fedekunze requested a review from noot as a code owner September 8, 2020 15:45
@fedekunze fedekunze merged commit d678370 into development Sep 8, 2020
@fedekunze fedekunze deleted the fedekunze/unmarshal-account branch September 8, 2020 15:58
@DeepalUsyD
Copy link

Thank you this solved the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants