This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Fix nonce issue for replay attack #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summerpro
approved these changes
Jan 8, 2021
fedekunze
approved these changes
Jan 8, 2021
Comment on lines
+1008
to
+1012
| if args.Nonce != nil { | ||
| if nonce != (uint64)(*args.Nonce) { | ||
| return nil, fmt.Errorf(fmt.Sprintf("invalid nonce; got %d, expected %d", (uint64)(*args.Nonce), nonce)) | ||
| } | ||
| } |
There was a problem hiding this comment.
nice, thanks for adding this client side validation!
@fedekunze can you check the changelog once more before merging? Thanks! |
|
@araskachoi this pr cannot close #687 , but can close #686 |
@summerpro is right |
agreed, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #687 #686
Description
Checks the nonce and requires the nonce to be the same as the account sequence.
before, the sequence needed to be greater than that of the nonce.
this fix will also throw an error when using an invalid nonce.
before, eth_sendTransaction would return a tx receipt even if the tx was rejected on the chain.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)