-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: upgrade golang.org/x/exp to latest #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasincs
changed the title
Upgrade golang.org/x/exp to latest
chore: Upgrade golang.org/x/exp to latest
Aug 7, 2023
tac0turtle
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
Given that people when depending on cosmos/gogoproto and trying to bump to latest pseudo version of |
julienrbrt
approved these changes
Aug 9, 2023
julienrbrt
changed the title
chore: Upgrade golang.org/x/exp to latest
refactor!: upgrade golang.org/x/exp to latest
Aug 17, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 8, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 8, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 8, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 8, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 8, 2023
beer-1
added a commit
to initia-labs/cosmos-sdk
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently golang.org/x/exp package decided to change function signature for SortFunc to align better with cmp package
reasoning is here:
golang/go#60091 (comment)
this is likely going to be standard for Go 1.21 and going forward