Fix SaveVersion() #260
Closed
Fix SaveVersion() #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this PR @Lbird! Would you mind updating the unit tests (specifically the failing |
This reverts commit 1735fa9. Deleting root node from recentDB doesn't help in terms of performance or memory.
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 68.60% 68.62% +0.01%
==========================================
Files 23 23
Lines 2472 2473 +1
==========================================
+ Hits 1696 1697 +1
Misses 599 599
Partials 177 177
|
|
@AdityaSripal Do you have any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving on snapshot version, delete flushed nodes and root hash from recentDB.
#256