Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pruning #274

Merged
merged 12 commits into from
Jun 24, 2020
Merged

remove pruning #274

merged 12 commits into from
Jun 24, 2020

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jun 23, 2020

Due to problems with data corruption (e.g. #261), performance, and resource usage (e.g. #256) we're removing pruning (introduced by #158 in 0.13.0) until it can be redesigned, as well as unreleased changes that built on it (e.g. FlushVersion and version metadata). All tests pass, and I've compared with 0.12.4 to make sure the core logic has changed as little as possible since then.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary ACK. Let me test this with the SDK, before an official one.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK

@erikgrinaker erikgrinaker merged commit bb7cd9c into master Jun 24, 2020
@erikgrinaker erikgrinaker deleted the erik/remove-pruning branch June 24, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants