-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pruning #274
remove pruning #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preliminary ACK. Let me test this with the SDK, before an official one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testedACK
Due to problems with data corruption (e.g. #261), performance, and resource usage (e.g. #256) we're removing pruning (introduced by #158 in 0.13.0) until it can be redesigned, as well as unreleased changes that built on it (e.g. FlushVersion and version metadata). All tests pass, and I've compared with 0.12.4 to make sure the core logic has changed as little as possible since then.