Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make GetVersioned() available after doing LazyLoadVersion #385

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

egonspace
Copy link
Contributor

I recreate a PR again in place of #358.

We can use LazyLoadVersion by #148.
But if we start app with LazyLoadVersion we cannot query app state by specific height because MutableTree.GetVersioned returns nil for other previous version after doing LazyLoadVersion.

Our nodes are facing a slow booting up problem because of the large app data, and I want to hear your opinion about whether we should modify the code like this.

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
utACK.

@egonspace
Copy link
Contributor Author

Test ci is not running. Is there anything else I need to do?

@robert-zaremba
Copy link
Collaborator

Test ci is not running. Is there anything else I need to do?

I've just re-run the tests and will merge it right after.

@robert-zaremba
Copy link
Collaborator

we will do a new release after merging this

@robert-zaremba robert-zaremba merged commit ac52606 into cosmos:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants