-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: add flat fee for queries to VerifyMembership
(backport #5927)
#6108
imp: add flat fee for queries to VerifyMembership
(backport #5927)
#6108
Conversation
Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 9aa7151) # Conflicts: # modules/core/02-client/keeper/grpc_query.go
Cherry-pick of 9aa7151 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Description
see cosmos/cosmos-sdk#9995 for similar flat gas consumption fee logic.
closes: #5902
i elected to consume the gas outside of the defer func as we are not operating on the cached context in this case, and simply consuming gas for the read on consensus state from the store...but open to other opinions if people have any!
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.Summary by CodeRabbit
This is an automatic backport of pull request #5927 done by [Mergify](https://mergify.com).