feat(depinject): support for 07-tendermint #6157

crodriguezvega · 2024-04-15T08:00:55Z

Description

Adding support for 07-tendermint package.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

coderabbitai · 2024-04-15T08:01:36Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

damiannolan

Everything looks good to go more or less, I think the branches are out of date tho?

I think we need the light client module for ModuleInputs.

damiannolan · 2024-04-16T20:59:27Z

modules/light-clients/07-tendermint/depinject.go

+
+// ProvideModule returns the 07-tendermint module outputs for dependency injection
+func ProvideModule(in ModuleInputs) ModuleOutputs {
+	m := NewAppModule()


I think this requires the light client module as an arg, right?

You're right, I fixed it now. I added the light client module as a module output though, let me know what you think.

…upport-tendermint # Conflicts: # go.mod

…ermint # Conflicts: # api/capability/v1/capability.pulsar.go # api/capability/v1/genesis.pulsar.go # api/go.mod # api/go.sum # api/ibc/applications/fee/v1/fee.pulsar.go # api/ibc/applications/fee/v1/query.pulsar.go # api/ibc/applications/fee/v1/tx.pulsar.go # api/ibc/applications/interchain_accounts/controller/v1/tx.pulsar.go # api/ibc/applications/interchain_accounts/host/v1/host.pulsar.go # api/ibc/applications/interchain_accounts/host/v1/tx.pulsar.go # api/ibc/applications/interchain_accounts/v1/account.pulsar.go # api/ibc/applications/interchain_accounts/v1/packet.pulsar.go # api/ibc/applications/transfer/v1/authz.pulsar.go # api/ibc/applications/transfer/v1/genesis.pulsar.go # api/ibc/applications/transfer/v1/query.pulsar.go # api/ibc/applications/transfer/v1/tx.pulsar.go # api/ibc/core/channel/v1/query.pulsar.go # api/ibc/core/channel/v1/tx.pulsar.go # api/ibc/core/client/v1/client.pulsar.go # api/ibc/core/client/v1/query.pulsar.go # api/ibc/core/client/v1/tx.pulsar.go # api/ibc/core/commitment/v1/commitment.pulsar.go # api/ibc/core/connection/v1/query.pulsar.go # api/ibc/core/connection/v1/tx.pulsar.go # api/ibc/lightclients/solomachine/v2/solomachine.pulsar.go # api/ibc/lightclients/solomachine/v3/solomachine.pulsar.go # api/ibc/lightclients/tendermint/v1/tendermint.pulsar.go # api/ibc/lightclients/wasm/v1/query.pulsar.go # api/ibc/lightclients/wasm/v1/tx.pulsar.go # e2e/go.mod # proto/buf.gen.pulsar.yaml

sonarcloud · 2024-04-18T21:38:09Z

Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

damiannolan

For light client modules we will probably need some kind of Invoker or something also on core to register on the router. But lgtm and can handle those parts later

crodriguezvega added 11 commits July 7, 2023 15:20

add generation of pulsar files

bb25487

remove wrong import

91d963b

Merge branch 'feat/depinject-support' into carlos/add-buf-gen-pulsar

0d97046

remove code that should come in a different PR

98a354f

Merge branch 'main' into carlos/add-buf-gen-pulsar

d41e1fa

Merge branch 'feat/depinject-support' into carlos/add-buf-gen-pulsar

dce72db

Merge branch 'main' into carlos/add-buf-gen-pulsar

66b7e15

update pulsar files

34e6e1c

api go mod tidy

17ce7dd

Merge branch 'main' into carlos/add-buf-gen-pulsar

c9f1eb1

feat(depinject): support for 07-tendermint

194908d

crodriguezvega requested review from colin-axner, AdityaSripal, damiannolan, srdtrk, chatton, charleenfei and DimitrisJim as code owners April 15, 2024 08:00

crodriguezvega mentioned this pull request Apr 15, 2024

Support SDK dependency injection for v2 apps #3560

Open

3 tasks

tidy all

0299a2e

damiannolan self-assigned this Apr 15, 2024

damiannolan and others added 3 commits April 16, 2024 17:36

chore: consolidate protogen scripts

b65ad37

Update Dockerfile

8428654

review comments

5769c8b

damiannolan approved these changes Apr 16, 2024

View reviewed changes

damiannolan removed their assignment Apr 16, 2024

crodriguezvega added 3 commits April 17, 2024 09:39

Merge branch 'feat/depinject' into carlos/add-buf-gen-pulsar

e779ba0

Merge branch 'carlos/add-buf-gen-pulsar' into carlos/3560-depinject-s…

3c41084

…upport-tendermint # Conflicts: # go.mod

add light client module to module outputs

d3186ad

lint

c92e915

Base automatically changed from carlos/add-buf-gen-pulsar to feat/depinject April 18, 2024 09:57

damiannolan approved these changes Apr 19, 2024

View reviewed changes

crodriguezvega merged commit f251968 into feat/depinject Apr 19, 2024
74 checks passed

crodriguezvega deleted the carlos/3560-depinject-support-tendermint branch April 19, 2024 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(depinject): support for 07-tendermint #6157

feat(depinject): support for 07-tendermint #6157

crodriguezvega commented Apr 15, 2024

coderabbitai bot commented Apr 15, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

damiannolan left a comment

damiannolan Apr 16, 2024

crodriguezvega Apr 17, 2024 •

edited

Loading

sonarcloud bot commented Apr 18, 2024

damiannolan left a comment

feat(depinject): support for 07-tendermint #6157

feat(depinject): support for 07-tendermint #6157

Conversation

crodriguezvega commented Apr 15, 2024

Description

coderabbitai bot commented Apr 15, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

damiannolan left a comment

Choose a reason for hiding this comment

damiannolan Apr 16, 2024

Choose a reason for hiding this comment

crodriguezvega Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Apr 18, 2024

Quality Gate passed for 'ibc-go'

damiannolan left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Apr 15, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

crodriguezvega Apr 17, 2024 •

edited

Loading