Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] msgServerV2 implementation #7302

Open
wants to merge 26 commits into
base: cian/nikolas/retreat-week-2
Choose a base branch
from

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Sep 17, 2024

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

* revert transfer test

* revert additional commit

* delete files

* remove multiack v1 logic

* remove getcounterpartyv2

* revert packetv1 to packetv2 conversions
@chatton
Copy link
Contributor

chatton commented Sep 19, 2024

This PR adds a V2 message server as an alternate approach to including the IBC protocol version in the Packet struct. The logic is effectively the same as in the eureka branch, but separated out into separate message servers instead of flagged by a version field.

@chatton chatton mentioned this pull request Sep 19, 2024
10 tasks
Copy link

sonarcloud bot commented Sep 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants