Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish1 #1506

Merged
merged 21 commits into from
Jul 31, 2023
Merged

Spanish1 #1506

merged 21 commits into from
Jul 31, 2023

Conversation

techagus
Copy link
Contributor

I keep getting confused with git management. I needed to create a new branch, spanish1

…ocalizable.strings, Main.strings y WindowPane.strings
…n blanco finales' en Main.strings y Localizable.strings
…ar todas las coincidencias encontradas' en Main.strings
…guiente' por 'siguiente elemento' en Main.strings
@techagus techagus requested a review from 1024jp as a code owner July 31, 2023 17:02
@techagus
Copy link
Contributor Author

I don't understand why the tests fail. Performing the AdHoc compilation, to test locally, using Xcode 15 beta works.

@1024jp 1024jp self-assigned this Jul 31, 2023
@1024jp 1024jp added the localization tasks related to application localization label Jul 31, 2023
@1024jp 1024jp added this to the 4.6.0 milestone Jul 31, 2023
Copy link
Member

@1024jp 1024jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1024jp 1024jp merged commit 4eb0916 into coteditor:main Jul 31, 2023
1 check failed
@1024jp
Copy link
Member

1024jp commented Jul 31, 2023

Thank you!

I keep getting confused with git management. I needed to create a new branch, spanish1

No problem. It is normal to create a new branch every time when creating a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization tasks related to application localization
Development

Successfully merging this pull request may close these issues.

2 participants