Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(headless-react): move to esm #3194

Merged
merged 19 commits into from
Sep 20, 2023

Conversation

mrrajamanickam-coveo
Copy link
Contributor

@mrrajamanickam-coveo mrrajamanickam-coveo commented Sep 19, 2023

  • Modify configs to make package esm and prep it for publishing to npm
    • Not adding a bundler as we are supporting only esm (and tsc is sufficient for now)
    • Tsconfig for the tests are not esm due to a bug in ts-jest
  • Minor changes to vscode workspace file - remove obsolete entry and reorder

https://coveord.atlassian.net/browse/KIT-2661

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 8d3ab8f.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Manifest Files

package-lock.json
  • mri@1.2.0
  • publint@0.2.2
  • sade@1.8.1
packages/headless-react/package.json
  • publint@0.2.2
  • rimraf@5.0.1

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 184.1 184.1 0
commerce 272.3 272.3 0
search 354.1 354.1 0
insight 305.9 305.9 0
product-listing 296.4 296.4 0
product-recommendation 158.2 158.2 0
recommendation 197.6 197.6 0
ssr 325.2 325.2 0

packages/headless-react/package.json Outdated Show resolved Hide resolved
packages/headless-react/package.json Outdated Show resolved Hide resolved
packages/headless-react/src/index.ts Outdated Show resolved Hide resolved
ui-kit.code-workspace Show resolved Hide resolved
Copy link
Contributor

@btaillon-coveo btaillon-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@mrrajamanickam-coveo
Copy link
Contributor Author

Quantic tests (unrelated to this PR) are failing with

read ECONNRESET
Error: read ECONNRESET
    at TCP.onStreamRead (node:internal/stream_base_commons:217:20)

Failures are not related to this PR. Proceeding to merge.

@mrrajamanickam-coveo mrrajamanickam-coveo merged commit df0ad6b into master Sep 20, 2023
85 of 88 checks passed
@mrrajamanickam-coveo mrrajamanickam-coveo deleted the KIT-2661_add_bundler_headless_react branch September 20, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants