Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newtonsoft.Json version and other nuget versions (use CPM) #1510

Merged
merged 26 commits into from
Aug 19, 2023

Conversation

Bertk
Copy link
Collaborator

@Bertk Bertk commented Jul 31, 2023

@Bertk Bertk force-pushed the update-all-nuget-versions branch 2 times, most recently from bde7c2d to e595642 Compare August 3, 2023 08:23
@Bertk Bertk changed the title Update all nuget versions Update Newtonsoft.Json version and also other nuget versions Aug 3, 2023
@Bertk Bertk force-pushed the update-all-nuget-versions branch from e595642 to 63f6b28 Compare August 3, 2023 14:05
@Bertk Bertk marked this pull request as ready for review August 3, 2023 14:07
@Bertk Bertk changed the title Update Newtonsoft.Json version and also other nuget versions Update Newtonsoft.Json version and other nuget versions Aug 3, 2023
@Bertk Bertk changed the title Update Newtonsoft.Json version and other nuget versions Update Newtonsoft.Json version and other nuget versions (using CPM) Aug 3, 2023
@Bertk Bertk changed the title Update Newtonsoft.Json version and other nuget versions (using CPM) Update Newtonsoft.Json version and other nuget versions (use CPM) Aug 3, 2023
@Bertk
Copy link
Collaborator Author

Bertk commented Aug 3, 2023

@MarcoRossignoli @daveMueller Please review PR.

@Bertk Bertk force-pushed the update-all-nuget-versions branch from 63f6b28 to f6d0adf Compare August 4, 2023 06:03
@Bertk Bertk marked this pull request as draft August 5, 2023 08:20
@Bertk Bertk marked this pull request as ready for review August 5, 2023 09:54
@Bertk Bertk force-pushed the update-all-nuget-versions branch from ae05b55 to 3ff04de Compare August 5, 2023 13:41
@Bertk Bertk force-pushed the update-all-nuget-versions branch from 944ccaa to f80ac39 Compare August 6, 2023 18:05
@Bertk Bertk force-pushed the update-all-nuget-versions branch from f80ac39 to 7df9aa0 Compare August 7, 2023 12:42
inputs:
version: 5.0.401
displayName: Install .NET Core SDK 5.0.401

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bertk Thanks a lot for your time-consuming contributions 🙏 . I've seen your comment in #1511 (comment) regarding this topic but PR was already merged at that time. I think you are right that we don't need them anymore. Especially if we migrate all the test projects to net6.0 like you have done in this PR.
Personally I'm not sure if we shouldn't keep 1-2 legacy netcoreapp3.1 projects to have a wider range of test scenarios regarding instrumentation... What do you think @MarcoRossignoli?
Thanks again, I really like the changes in this PR and will try to do a proper review in the next days.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to test and ship only supported versions announced here https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-and-net-core

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shows supported versions much better 😉
https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

@MarcoRossignoli
Copy link
Collaborator

@daveMueller is this good to go?

@daveMueller
Copy link
Collaborator

@daveMueller is this good to go?

Sorry didn't find time yet to look into it. Most likely on the weekend.

Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Show resolved Hide resolved
Documentation/Examples/MSBuild/DeterministicBuild/HowTo.md Outdated Show resolved Hide resolved
Documentation/Examples/MSBuild/DeterministicBuild/HowTo.md Outdated Show resolved Hide resolved
eng/publish-coverlet-result-files.yml Outdated Show resolved Hide resolved
eng/publish-coverlet-result-files.yml Outdated Show resolved Hide resolved
eng/publish-coverlet-result-files.yml Outdated Show resolved Hide resolved
eng/build.yml Show resolved Hide resolved
eng/build.yml Show resolved Hide resolved
@daveMueller daveMueller merged commit 1da3e1c into coverlet-coverage:master Aug 19, 2023
8 checks passed
@Bertk Bertk deleted the update-all-nuget-versions branch August 20, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Mono.Cecil dependency version to 0.11.4
3 participants