Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deterministic build for msbuild driver #796

Merged

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Apr 6, 2020

contributes to #363

@clairernovotny @tmat @tonerdo the main files to check are:

DeterministicBuild.targets -> workaround
src/coverlet.core/Helpers/SourceRootTranslator.cs -> path translator
test/coverlet.core.tests/Helpers/SourceRootTranslatorTests.cs -> tests
src/coverlet.msbuild.tasks/coverlet.msbuild.targets -> target for tests project

All other updates are tests fix and DI container update.

@clairernovotny
Copy link
Contributor

Where is DeterministicBuild.targets being used? Just for the local project?

There'll need to be a doc update that tells people they'll need that in their Directory.Build.targets until some future SDK update.

@MarcoRossignoli
Copy link
Collaborator Author

Where is DeterministicBuild.targets being used? Just for the local project?

Is imported here https://github.com/tonerdo/coverlet/pull/796/files#diff-56f8482aeb786dd105fbf93dedf2615f

There'll need to be a doc update that tells people they'll need that in their Directory.Build.targets until some future SDK update.

Yes it's the last point in the list #363 (comment) I'll add samples for msbuild and collector here https://github.com/tonerdo/coverlet/blob/master/Documentation/Examples.md before release package.

@MarcoRossignoli
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli MarcoRossignoli added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 6, 2020
@MarcoRossignoli MarcoRossignoli removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2020
@MarcoRossignoli
Copy link
Collaborator Author

@clairernovotny @tmat let me know if the translation alg and props/targets are ok to you and I'll take another review round and after I'll merge and I'll go ahead with the todo list.

@MarcoRossignoli MarcoRossignoli merged commit 39d83be into coverlet-coverage:master Apr 8, 2020
@MarcoRossignoli MarcoRossignoli deleted the deterministicbuild branch April 8, 2020 18:46
@MarcoRossignoli
Copy link
Collaborator Author

@clairernovotny tomorrow if you want you can try with nightly build, it's the most "official" after nuget release https://github.com/tonerdo/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants