Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6 breakdown pt1 - add codegen #9

Merged
merged 11 commits into from
Sep 4, 2024
Merged

#6 breakdown pt1 - add codegen #9

merged 11 commits into from
Sep 4, 2024

Conversation

yvesfracari
Copy link
Collaborator

@yvesfracari yvesfracari commented Aug 15, 2024

original PR: #6

Added code generation capabilities

  • Introduced web3_codegen in Makefile
  • Updated codegen target to include Web3, orderbook, and subgraph codegen

Refactored project structure

  • Removed contracts/ files (domain.py, order.py, sign.py)
  • Eliminated order_book/ directory and contents
  • Removed examples/ directory

Updated documentation

  • Revised README.md for latest project structure
  • Added note about signing orders in usage examples

Updated Chain enum for consistent explorer URL formatting

  • Simplified imports in web3/provider.py
  • Adjusted test suite, removing tests for refactored/removed components

@yvesfracari yvesfracari changed the base branch from cow-0-configs to main August 16, 2024 12:52
@yvesfracari yvesfracari requested review from ribeirojose and mendesfabio and removed request for mfw78 August 20, 2024 13:26
Copy link
Collaborator

@ribeirojose ribeirojose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote most of the commits here, so this is a bit weird 😆 but LGTM!

@gabrielfior
Copy link
Collaborator

I might be missing context, but I miss a bit of documentation here (in a README)

  • How can one generate the autogen code
  • Which package used
  • When to update if needed

@yvesfracari yvesfracari requested review from gabrielfior and removed request for mendesfabio August 26, 2024 21:21
README.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@ribeirojose
Copy link
Collaborator

I might be missing context, but I miss a bit of documentation here (in a README)

  • How can one generate the autogen code
  • Which package used
  • When to update if needed

I added more instructions here. Lmk if that looks good and I'll go ahead and merge this =)

@ribeirojose ribeirojose merged commit a0bb9d9 into main Sep 4, 2024
3 checks passed
@ribeirojose ribeirojose deleted the cow-1-codegen branch September 4, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants