Support for standard paper sizes (ISO 216) and orientation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param arg a Dimension instance, a List<Number> [width, height] or the name of a standard paper size ("a4", "letter", "legal") | ||
| */ | ||
| void setSize(def arg) { |
There was a problem hiding this comment.
This is great!
Can you change this to 3 individually overloaded setSize methods? setSize(Dimension size) setSize(List size) etc?
There was a problem hiding this comment.
Yeah, sure! I'll fix it.
|
Definitely a needed improvement. Thanks, man! |
craigburke
added a commit
that referenced
this pull request
Feb 20, 2016
Support for standard paper sizes (ISO 216) and orientation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letter paper size was hard-coded in Document. I added support for specifying paper size and also added support for shortcuts to some common standard paper sizes like "Letter", "Legal", "A4", "A5", etc.
I also added support for specifying orientation "portrait" and "landscape".
Orientation and paper size is set on the Document instance so it's not possible to have some pages portrait and some landscape.
Tested ok with Word and PDF.
https://en.wikipedia.org/wiki/ISO_216