Skip to content

Commit

Permalink
Don't set Stdin/Stdout/Stderr if already set (#71)
Browse files Browse the repository at this point in the history
* only set stdout and stderr if not already set

* Don't set cmd.Stdin if it's already set

Considered @craek's codereview
  • Loading branch information
xaionaro authored and creack committed Mar 18, 2019
1 parent 7dc38fb commit 521317b
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions run.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,15 @@ func StartWithSize(c *exec.Cmd, sz *Winsize) (pty *os.File, err error) {
return nil, err
}
}
c.Stdout = tty
c.Stdin = tty
c.Stderr = tty
if c.Stdout == nil {
c.Stdout = tty
}
if c.Stderr == nil {
c.Stderr = tty
}
if c.Stdin == nil {
c.Stdin = tty
}
if c.SysProcAttr == nil {
c.SysProcAttr = &syscall.SysProcAttr{}
}
Expand Down

0 comments on commit 521317b

Please sign in to comment.