revert of #167 seem is not sufficient #196
Comments
jsoriano
added a commit
to elastic/elastic-package
that referenced
this issue
Jun 26, 2024
Use the helper `pty.Start()` instead of handling ourselves the tty and associated ptty. Wait for the finalization of the command just with the copy, to avoid a separate goroutine in an attempt to avoid the hangs we are seeing in CI. Downgrade to pty 1.1.19, that seems to solve some kind of race condition creack/pty#196 that could be producing the hangs. Co-authored-by: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in #177, it reverted #167, however, the revert seems not sufficient. we uses buildkite agent which depends on this pty package's v1.1.21. However, we are still seeing
when PTY is enabled.
Note that v1.1.21 does help in that the occurrence of this bug is lower than v1.1.20. However, it just still happens at a lower rate.
See buildkite/agent#2790 for more details of the bug.
The text was updated successfully, but these errors were encountered: