Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error #99

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Better error #99

merged 2 commits into from
Mar 21, 2023

Conversation

big-andy-coates
Copy link
Member

Trivial change to error message to make it clear the list of descriptors is the list of creatable descriptors known to the system.

Reviewer checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant, how
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Ensure any appropriate documentation has been added or amended

@big-andy-coates
Improve error message on non-creatable resource
c5b2273 
Trivial change to make it clear the list of descriptors is the list of _creatable_ descriptors known to the system.
@big-andy-coates
Improve test coverage of unrelated
a13be9b 
...which was cause a warning on commit each time.
@big-andy-coates big-andy-coates added the enhancement New feature or request label Mar 21, 2023
@big-andy-coates big-andy-coates requested a review from a team as a code owner March 21, 2023 14:00
@big-andy-coates big-andy-coates merged commit 5ffb2fc into main Mar 21, 2023
@big-andy-coates big-andy-coates deleted the better-error branch March 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@big-andy-coates