Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gas consumption issue for ConditionTypeVote #23

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

queencre
Copy link
Contributor

Description

This PR fixes gas consumption issue for ConditionTypeVote for the claim module.

Tasks

  • Add UpgradeHeight in app/upgrades/mainnet/v1.0.0/upgrade.go
  • Add upgrade logic when ValidateCondition
  • Add keeper test case to compare before and after the fix

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crypin crypin marked this pull request as ready for review April 14, 2022 08:14
@crypin crypin self-requested a review as a code owner April 14, 2022 08:14
Copy link
Contributor

@kingcre kingcre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crypin crypin merged commit eb46f97 into crescent-network:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app bug Something isn't working x/claim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants