Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add mint pool address for mint module #316 #35

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

crypin
Copy link
Member

@crypin crypin commented May 23, 2022

Description

Summary

Add params.MintPoolAddress on the mint module to customize and separate collected tx fee from FeeCollector

Proposal

mint_pool_address defines the address where inflation will be minted, The default is FeeCollector It's the same value that's currently hardcoded, but if it set to FeeCollector, minted inflation could be mixed together with collected tx fees. Therefore, it is recommended to specify a separate address depending on the chain

Tasks

  • Add MintPool on mint module feat!: add mint pool address for mint module cosmosquad-labs/squad#316
  • Change Mint Pool from default cre17xpfvakm2amg962yls6f84z3kell8c5l53s97s (fee_collector) to cre1m3h30wlvsf8llruxtpukdvsy0km2kum8ve5ajd (mint module acc) (to prevent mixing of inflation and tx fee)
  • Change the source address of Budgets whose source address is cre17xpfvakm2amg962yls6f84z3kell8c5l53s97s to cre1m3h30wlvsf8llruxtpukdvsy0km2kum8ve5ajd
  • add Budget to sending staking reward, and community fund to cre17xpfvakm2amg962yls6f84z3kell8c5l53s97s from cre1m3h30wlvsf8llruxtpukdvsy0km2kum8ve5ajd

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crypin crypin marked this pull request as ready for review May 23, 2022 04:39
Copy link
Contributor

@queencre queencre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crypin crypin merged commit 1732fec into main Jun 16, 2022
@kingcre kingcre deleted the cherry-pick/316 branch August 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants