feat!: add mint pool address for mint module #316 #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Add
params.MintPoolAddress
on the mint module to customize and separate collected tx fee fromFeeCollector
Proposal
mint_pool_address
defines the address where inflation will be minted, The default isFeeCollector
It's the same value that's currently hardcoded, but if it set toFeeCollector
, minted inflation could be mixed together with collected tx fees. Therefore, it is recommended to specify a separate address depending on the chainTasks
cre17xpfvakm2amg962yls6f84z3kell8c5l53s97s (fee_collector)
tocre1m3h30wlvsf8llruxtpukdvsy0km2kum8ve5ajd (mint module acc)
(to prevent mixing of inflation and tx fee)cre17xpfvakm2amg962yls6f84z3kell8c5l53s97s
tocre1m3h30wlvsf8llruxtpukdvsy0km2kum8ve5ajd
cre17xpfvakm2amg962yls6f84z3kell8c5l53s97s
fromcre1m3h30wlvsf8llruxtpukdvsy0km2kum8ve5ajd
References
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes