Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login form being submitted to /sso instead of /login #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rubensayshi
Copy link

Tbh I'm not 100% certain about this fix, because it's been like this since the very first commit adding the login form... but I can't see how this has ever worked...

If the login form submits to /sso then it will hit the req.Validate() and it will fail with a http.StatusBadRequest.
technically if it would get past that check it would then actually read the form payload, but I don't know how it ever can ...

is it possible nobody has been using the /login endpoint for a long time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant