Clean old discovery metadata aerospike-namespaces #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoron
requested changes
Feb 23, 2024
configs/aerospike_config.yaml
Outdated
| # The key to discover Aerospike's namespaces through service discovery | ||
| # Set it to "" to instead discover namespaces automatically via the info command | ||
| # DEPRECATED since 02/19/2024 | ||
| namespace_meta_key: "aerospike-namespaces" | ||
| # The key prefix to discover Aerospike's namespaces through service discovery | ||
| # old "namespace_meta_key" has been DEPRECATED because of 512 bytes limitation of the value in consul. |
There was a problem hiding this comment.
I don't think keeping this comment bring useful information (it is in commit messages)
There was a problem hiding this comment.
Absolutely, patching it !
pkg/aerospike/discovery.go
Outdated
| if !ready { | ||
| continue | ||
| } | ||
| ns := metaKey[len(conf.AerospikeEndpointConfig.NamespaceMetaKeyPrefix):] // MetaKey is like : "aerospike-monitoring-closeststore" | ||
| // MetaKey is like : "aerospike-monitoring-closeststore" |
There was a problem hiding this comment.
I would remove reference to a real namespace, use foobar instead
pgoron
approved these changes
Feb 26, 2024
* This metadata is no more added to consul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.