-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting custom options #12
Conversation
I understand the intent. I made it non-public on purpose: so that only known options be set in a controlled way. I suggest, instead of simply changing the |
Perfect! |
@crocodile2u I've updated the PR with the |
Thanks @peterjaap ! I'll create a new release now ;-) |
Version 2.0.5 is here: https://github.com/crocodile2u/imgproxy-php/releases/tag/v2.0.5 |
@crocodile2u awesome, thanks for the quick turnaround and the constructive feedback! |
Changing the visibility of the
set()
method in theOptionSet
class from private to public allows us to set arbitrary settings using a text string.For example, I want to be able to do this;
For a real life example, see elgentos/magento2-imgproxy@50f1455#diff-c5ca923b6d96fb8bb165a2634b824b6209bb35097555ff7cad065506f35b0c0cR77