Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to log.warning instead of log.warn #1648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jenselme
Copy link
Contributor

log.warn is removed in Python 3.13

Close #1098

log.warn is removed in Python 3.13

Close crossbario#1098
@Jenselme
Copy link
Contributor Author

From what I understand of the error, I may be completely wrong on how to solve this: I seem to have modified calls to twited Logger class which does use warn. So the issue about warn being deprecated may come from a dependency and not this packages directly (nor txaio).

Testing this properly is made harder by the fact that pyunormalize cannot be installed on Python 3.13 yet

Any insights no this?

@oberstet
Copy link
Contributor

thanks for taking care of such things .. pls lemme comment ..

log.warn is removed in Python 3.13

if so, then

  • the CI in Autobahn should first be upgraded to 3.13 in an independent PR
  • this should then run red (fail), because the function is removed

once that is done, this PR can continue ..


right now, 3.13 is not yet released

grafik


currently, the CI uses CPython 3.11 and PyPy 3.9

python-version: ['3.9', '3.11', 'pypy-3.9']

and PyPy is now at 3.10

https://pypy.org/download.html

for the CI upgrade PR, we should first define the exact version goals for CPython and for PyPy ..

@Jenselme
Copy link
Contributor Author

Sounds good to me. I started looking into it because fedora is starting to switch to 3.13 in its dev version and it seemed easy to do (sadly I was proven wrong).

But, yes, we can wait for Python 3.13 to be officially release and migrate the CI first.

@oberstet
Copy link
Contributor

oberstet commented Aug 23, 2024

But, yes, we can wait for Python 3.13 to be officially release and migrate the CI first.

I'm confident this ordering will support Autobahn's goal of improving robustness & production stability.

if there is an issue in Autobahn triggered by a dependency upgrade, the issue should first be proven to actually exist and be valid

this requires the CI to first not touch any code, but only upgrade the dependency, and then demoonstrate at least one failing test (which previously worked).

if no such test currently exists which can demonstrate the issue, a new test case should be added

once the issue is confirmed (by a test that transitioned from GREEN to RED), the issue can be fixed in another PR

this allows to exactly follow the sequence of events with proof at each step, and the option for relatively easy rollback should something go wrong. as there will more often than not in reality;)

like ripples in a subsequent, dependent project like Crossbar.io (which obviously uses Autobahn a lot) ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logger.warn is removed in Python 3.13
2 participants