-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: cosmos-sdk 0.46.1 is not used #850
Conversation
Solution: - update cosmos-sdk and remove custom tx fee checker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should ibc-go be bumped to rc0? https://github.com/cosmos/ibc-go/releases/tag/v5.0.0-rc0
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 16.71% 18.93% +2.22%
==========================================
Files 93 93
Lines 11648 11864 +216
==========================================
+ Hits 1947 2247 +300
+ Misses 9243 9135 -108
- Partials 458 482 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sounds good, done. |
/runsim |
Simulation tests started and triggered by |
✅ |
* Problem: cosmos-sdk 0.46.1 is not used Solution: - update cosmos-sdk and remove custom tx fee checker. * upgrade ibc-go
* Problem: cosmos-sdk 0.46.1 is not used Solution: - update cosmos-sdk and remove custom tx fee checker. * upgrade ibc-go
Solution:
The priority mechanism change is backported upstream.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)