Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cosmos-sdk 0.46.1 is not used #850

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 25, 2022

Solution:

  • update cosmos-sdk and remove custom tx fee checker.

The priority mechanism change is backported upstream.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update cosmos-sdk and remove custom tx fee checker.
@yihuang yihuang requested a review from a team as a code owner August 25, 2022 01:13
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #850 (64c2b9c) into master (fe6dc04) will increase coverage by 2.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   16.71%   18.93%   +2.22%     
==========================================
  Files          93       93              
  Lines       11648    11864     +216     
==========================================
+ Hits         1947     2247     +300     
+ Misses       9243     9135     -108     
- Partials      458      482      +24     
Flag Coverage Δ
integration_tests 16.62% <ø> (-0.10%) ⬇️
unit_tests 6.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 29.31% <ø> (-22.90%) ⬇️
x/icaauth/types/params.pb.go 1.20% <0.00%> (ø)
x/nft/simulation/operations.go 0.00% <0.00%> (ø)
app/state.go 0.00% <0.00%> (ø)
x/nft/keeper/querier.go 5.26% <0.00%> (+1.75%) ⬆️
x/nft/keeper/invariants.go 3.92% <0.00%> (+3.92%) ⬆️
x/icaauth/types/message_submit_tx.go 10.25% <0.00%> (+10.25%) ⬆️
x/nft/keeper/nft.go 22.68% <0.00%> (+12.60%) ⬆️
x/nft/types/validation.go 50.00% <0.00%> (+14.28%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 25, 2022

should ibc-go be bumped to rc0? https://github.com/cosmos/ibc-go/releases/tag/v5.0.0-rc0

sounds good, done.

@devashishdxt
Copy link
Collaborator

/runsim

@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

@github-actions
Copy link

/runsim simulation test has succeeded 🎉
Can further check here

@yihuang yihuang merged commit 4b0c725 into crypto-org-chain:master Aug 25, 2022
@yihuang yihuang deleted the sdk-46-1 branch August 25, 2022 07:16
devashishdxt pushed a commit to devashishdxt/chain-main that referenced this pull request Sep 23, 2022
* Problem: cosmos-sdk 0.46.1 is not used

Solution:
- update cosmos-sdk and remove custom tx fee checker.

* upgrade ibc-go
tomtau pushed a commit that referenced this pull request Sep 23, 2022
* Problem: cosmos-sdk 0.46.1 is not used

Solution:
- update cosmos-sdk and remove custom tx fee checker.

* upgrade ibc-go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants