Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to n-api #160

Merged
merged 31 commits into from
Jan 9, 2020
Merged

Update to n-api #160

merged 31 commits into from
Jan 9, 2020

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented Jan 1, 2020

node@8 not supported anymore, it's good switch to n-api, because it's not require adjust cpp code on each v8 change (as NAN).

Also:

  • added prebuilds (prebuildify) with GitHub Actions
  • removed second pure js implementation
  • slightly changed api, now not require Buffer
  • only 1 dependency -- elliptic, except node-addon-api/node-gyp-build for building addon

@kumavis
Copy link

kumavis commented Jan 3, 2020

Fixes #161 🙌

@fanatid fanatid merged commit 6cfdf24 into master Jan 9, 2020
@fanatid fanatid deleted the n-api branch January 9, 2020 09:00
@junderw junderw added this to the 4.0.0 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants