add stat cache to sharesstorageprovider #3940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
kobergj
approved these changes
Jun 6, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
sharesstorageprovidercache
branch
from
0047cdc
to
29ff1a4
Compare
dragotin
approved these changes
Jun 13, 2023
| c.StatCache.Store = "noop" | ||
| } | ||
| if c.StatCache.TTL == 0 { | ||
| c.StatCache.TTL = 30 // 30sec is the default desktop client poll interval |
There was a problem hiding this comment.
Why is the desktop client poll interval important here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After disabling the cache in the gateway we added a statcache to the sharesstorageprovider to make the share jail more efficient.