always find unique providers #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
reviewed
Jun 26, 2024
butonic
force-pushed
the
always-find-unique
branch
4 times, most recently
from
391ccc6
to
2fde371
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
always-find-unique
branch
from
2fde371
to
af606e7
Compare
butonic
commented
Jul 16, 2024
| return client, p[0], err | ||
| } | ||
|
|
||
| // FIXME findAndUnwrap currently just returns the first provider ... which may not be what is needed. | ||
| // for the ListRecycle call we need an exact match, for Stat and List we need to query all related providers |
There was a problem hiding this comment.
the gateway is no longer smart. it does not aggregate any directories. clients have to do that now.
|
@kobergj green save the fossa check |
kobergj
approved these changes
Jul 16, 2024
|
ocis test run was green: owncloud/ocis#9621 |
This was referenced Jul 29, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gateway will now always try to find a single unique provider. It has stopped aggregating multiple ListContainer responses when we removed any business logic from it.
related: