Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takeAppOfflineFlag should be false when not given instead of throwing error Unexpected end of JSON input #2

Merged
merged 3 commits into from
Jun 6, 2020
Merged

takeAppOfflineFlag should be false when not given instead of throwing error Unexpected end of JSON input #2

merged 3 commits into from
Jun 6, 2020

Conversation

gojanpaolo
Copy link
Contributor

No description provided.

@gojanpaolo gojanpaolo mentioned this pull request Jun 6, 2020
Merged
cschleiden
cschleiden approved these changes Jun 6, 2020
View reviewed changes
dist/index.js Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
gojanpaolo and others added 2 commits June 6, 2020 13:41
@gojanpaolo @cschleiden
Use double quotes for string literals
8348ab0 
Co-authored-by: Christopher Schleiden <cschleiden@live.de>
@gojanpaolo @cschleiden
Use double quotes for string literals
de1e0b9 
Co-authored-by: Christopher Schleiden <cschleiden@live.de>
@cschleiden cschleiden merged commit 4cf3545 into cschleiden:master Jun 6, 2020
@cschleiden
Copy link
Owner

Thanks! Taking a look at the other PR, going to release a new version with both changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschleiden cschleiden cschleiden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gojanpaolo @cschleiden