Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

create SourceLink.Embed.AllSourceFiles nupkg #205

Closed
ctaggart opened this issue May 1, 2017 · 1 comment
Closed

create SourceLink.Embed.AllSourceFiles nupkg #205

ctaggart opened this issue May 1, 2017 · 1 comment
Milestone

Comments

@ctaggart
Copy link
Owner

ctaggart commented May 1, 2017

An alternative to embedding source link json, is just to embed all the sources. It is more difficult right now that it should be. It also is different in C# than in F# projects. It would be great to allow users to switch easily between.

dotnet/roslyn#19127

@ctaggart
Copy link
Owner Author

ctaggart commented May 2, 2017

Like SourceLink.Create there will be at least a couple variations of embed. I'm thinking:

  • SourceLink.Embed.AllSourceFiles
  • SourceLink.Embed.PaketFiles

Both should simply be this, but the first one without the condition.

https://github.com/fsprojects/Paket/blob/master/src/Directory.Build.targets

<Project>
  <PropertyGroup>
    <BuildDependsOn>EmbedPaketFiles;$(BuildDependsOn)</BuildDependsOn>
  </PropertyGroup>
  <Target Name="EmbedPaketFiles">
    <ItemGroup>
      <EmbeddedFiles Include="$([System.IO.Path]::GetFullPath('%(Compile.Identity)'))"
        Condition="$([System.String]::Copy('%(Identity)').Contains('paket-files'))" />
    </ItemGroup>
    <CreateProperty Value="@(EmbeddedFiles)">  
      <Output TaskParameter="Value" PropertyName="embed" />  
    </CreateProperty>
  </Target>
</Project>

@ctaggart ctaggart changed the title create SourceLink.EmbedAllSources nupkg create SourceLink.Embed.AllSources nupkg May 2, 2017
@ctaggart ctaggart changed the title create SourceLink.Embed.AllSources nupkg create SourceLink.Embed.AllSourceFiles nupkg May 2, 2017
@ctaggart ctaggart added this to the 2.1.1 milestone May 2, 2017
ctaggart added a commit that referenced this issue May 2, 2017
* create SourceLink.Embed.AllSourceFiles nupkg #205

* updated readme for embedding

* only portable or embedded

* updated known issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant