Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #31 #32

Merged
merged 4 commits into from
Jan 23, 2022
Merged

Fix #31 #32

merged 4 commits into from
Jan 23, 2022

Conversation

dobraczka
Copy link
Contributor

Wrapping inner contextmanager correctly to make module and api work in the same and expected manner.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #32 (952f78c) into main (7ba8453) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   59.18%   59.53%   +0.34%     
==========================================
  Files          10       10              
  Lines         691      692       +1     
  Branches      118      119       +1     
==========================================
+ Hits          409      412       +3     
+ Misses        263      261       -2     
  Partials       19       19              
Impacted Files Coverage Δ
src/pystow/api.py 57.74% <100.00%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba8453...952f78c. Read the comment docs.

@cthoyt
Copy link
Owner

cthoyt commented Jan 23, 2022

Hi @dobraczka, I thought testing this would take a while and did a few roundabout PRs in the mean time, but it turns out I already had something written. Your solution had a spurious list wrapping the yield value, so I fixed that and it should be ready to merge now.

@cthoyt cthoyt merged commit 0520fcc into cthoyt:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants