Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic ensure #43

Merged
merged 11 commits into from
Jul 1, 2022
Merged

Generic ensure #43

merged 11 commits into from
Jul 1, 2022

Conversation

mberr
Copy link
Collaborator

@mberr mberr commented Jun 22, 2022

This PR adds another ensure method, which uses a user-provided callable to generate the file, if it is not present.

@mberr mberr marked this pull request as draft June 22, 2022 07:58
@mberr
Copy link
Collaborator Author

mberr commented Jun 22, 2022

can't reproduce https://github.com/cthoyt/pystow/runs/7010203920?check_suite_focus=true locally under Python 3.8. It looks like the keyword-based parameters are passed as positional instead.

@mberr mberr marked this pull request as ready for review June 27, 2022 16:47
@mberr mberr requested a review from cthoyt June 27, 2022 17:00
Copy link
Owner

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mberr thanks for being patient... this one fell of the radar for a bit

@cthoyt cthoyt merged commit 44f21d2 into main Jul 1, 2022
@cthoyt cthoyt deleted the generic-ensure branch July 1, 2022 14:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants