Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification that ensure_csv uses tab separations #52

Merged
merged 6 commits into from
Aug 12, 2022

Conversation

sgbaird
Copy link
Contributor

@sgbaird sgbaird commented Aug 6, 2022

Closes #51

Feel free to modify, nix, or add as you like!

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #52 (df2d05e) into main (321d98e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   65.01%   65.01%           
=======================================
  Files          10       10           
  Lines         906      906           
  Branches      153      153           
=======================================
  Hits          589      589           
  Misses        296      296           
  Partials       21       21           
Impacted Files Coverage Δ
src/pystow/api.py 69.28% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

README.md Outdated
import pystow
import pandas as pd

url = 'https://raw.githubusercontent.com/pykeen/pykeen/master/src/pykeen/datasets/nations/test.txt'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a tab-separated dataset... not sure this example makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Added a different file.

@cthoyt cthoyt merged commit d84f24d into cthoyt:main Aug 12, 2022
@cthoyt
Copy link
Owner

cthoyt commented Aug 12, 2022

Thanks @sgbaird :)

@sgbaird sgbaird deleted the patch-1 branch August 12, 2022 22:13
@sgbaird
Copy link
Contributor Author

sgbaird commented Aug 12, 2022

Sure thing! Thanks for the patience with my questions and requests 🙂

@cthoyt
Copy link
Owner

cthoyt commented Aug 12, 2022

Any time, if you've got suggestions for more things in PyStow I'm happy to implement new things or accept PRs

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading comma-separated values format defaults to tab separators
3 participants