Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple WorldInit derivers conflicting implementation in single module (#148) #150

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Fix multiple WorldInit derivers conflicting implementation in single module (#148) #150

merged 3 commits into from
Nov 3, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Nov 1, 2021 •
edited by tyranron
Loading

Resolves #148

Synopsis

Having multiple WorldInit derivers produces multiple structs with same names (CucumberGiven, CucumberWhen, CucumberThen).

Solution

Add struct name at the end to fix error conflicting implementation for CucumberThen.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added bug Something isn't working enhancement Improvement of existing features or bugfix labels Nov 1, 2021
@ilslv ilslv self-assigned this Nov 1, 2021
@ilslv ilslv added this to the 0.10.2 milestone Nov 1, 2021
@ilslv ilslv changed the title Draft: Fix two WorldInit derivers conflicting implementation in single module (#148) Draft: Fix multiple WorldInit derivers conflicting implementation in single module (#148) Nov 1, 2021
@ilslv
Copy link
Member Author

ilslv commented Nov 1, 2021 •
edited by tyranron
Loading

FCM

Fix multiple `WorldInit` derivers conflicting implementations in a single module (#150, #148)

@ilslv ilslv requested a review from tyranron November 1, 2021 05:52
@ilslv ilslv mentioned this pull request Nov 1, 2021
Closed
@ilslv ilslv marked this pull request as ready for review November 1, 2021 05:59
@ilslv ilslv changed the title Draft: Fix multiple WorldInit derivers conflicting implementation in single module (#148) Fix multiple WorldInit derivers conflicting implementation in single module (#148) Nov 1, 2021
@tyranron tyranron removed the bug Something isn't working label Nov 3, 2021
@tyranron tyranron merged commit 15b5fe6 into main Nov 3, 2021
@tyranron tyranron deleted the 148-fix-multiple-worlds branch November 3, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.

Multiple World fails
2 participants
@ilslv @tyranron