Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser skipping files named .feature #201

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Fix parser skipping files named .feature #201

merged 6 commits into from
Jan 31, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Jan 31, 2022 •
edited by tyranron
Loading

Synopsis

parser::Basic skips files named .feature, because of how Path::extension() is implemented in standard library.

Solution

Remove that additional check.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Jan 31, 2022
@ilslv ilslv added this to the 0.11.3 milestone Jan 31, 2022
@ilslv ilslv self-assigned this Jan 31, 2022
@ilslv
Copy link
Member Author

ilslv commented Jan 31, 2022 •
edited by tyranron
Loading

FCM

Fix `parser::Basic` skipping files named `.feature` (#201)

@tyranron
Copy link
Member

@ilslv please, disolve book tests stuff into a separate PR.

@ilslv ilslv requested a review from tyranron January 31, 2022 12:24
@ilslv ilslv mentioned this pull request Jan 31, 2022
Merged
15 tasks
@tyranron tyranron merged commit 3444ef7 into main Jan 31, 2022
@tyranron tyranron deleted the remove-extension-check branch January 31, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron