Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retries with fail on skipped (#249) #250

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Fix retries with fail on skipped (#249) #250

merged 6 commits into from
Dec 7, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 7, 2022 •
edited by tyranron
Loading

Synopsis

#249

Solution

Don't pass info about number of retries, when transforming Skipped event into a Failed.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests labels Dec 7, 2022
@ilslv ilslv self-assigned this Dec 7, 2022
@ilslv
Copy link
Member Author

ilslv commented Dec 7, 2022 •
edited by tyranron
Loading

FCM

Fix not panicking on `fail_on_skipped()` with retries (#250, #249)

- add `NotFound` variant to `event::StepError`

@ilslv ilslv added this to the 0.17.1 milestone Dec 7, 2022
@ilslv ilslv marked this pull request as draft December 7, 2022 10:43
@ilslv ilslv marked this pull request as ready for review December 7, 2022 13:30
@ilslv ilslv requested a review from tyranron December 7, 2022 13:56
@tyranron tyranron added k::design Related to overall design and/or architecture k::api Related to API (application interface) labels Dec 7, 2022
tyranron
tyranron approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv thanks! 🍻

@tyranron tyranron merged commit a585e5a into main Dec 7, 2022
@tyranron tyranron deleted the 249-retry-fail-on-skipped branch December 7, 2022 17:02
@tyranron tyranron mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::testing Related to testing and/or automated tests
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron