Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing feature and scenario headers #300

Merged

Conversation

Daanoz
Copy link
Contributor

@Daanoz Daanoz commented Aug 24, 2023

Another fix for the terminal log prints when color is on. Should relate to #299 (and maybe #282).

If I understand the principle, each step is first printed in white and after the step is done, the white line is replaced by either green or red text, depending on the outcome. However, during feature and scenario start the lines_to_clear is also incremented. When the first the step of a scenario completes it replaces those 3 lines (feature start, scenario start, step start) with 1 line being the green/red step complete. I could not find a use-case where it made sense to replace these lines as well.

@Daanoz Daanoz force-pushed the fix/missing-scenario-feature-headers branch from 182e221 to a930976 Compare August 24, 2023 13:01
@tyranron tyranron added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Sep 14, 2023
@tyranron tyranron added this to the 0.21.0 milestone Sep 14, 2023
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Daanoz sorry for the long delay, and thank you for the fix! 🍻

@tyranron tyranron merged commit 62579b0 into cucumber-rs:main Sep 14, 2023
42 checks passed
@Daanoz
Copy link
Contributor Author

Daanoz commented Sep 25, 2023

No problem, any idea when this as part of 0.21 would be available?

@Daanoz Daanoz deleted the fix/missing-scenario-feature-headers branch September 25, 2023 13:01
@tyranron
Copy link
Member

@Daanoz after merging #302. In a week or so.

@tyranron
Copy link
Member

@Daanoz sorry for being late. Released as 0.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants