JSON Formatter only escapes first space character in feature Id

[simondean]

Hi. There's a bug in the JSON formatter in the way that spaces are escaped in the feature ID. Only the first space in a feature name is escaped with a hyphen.

[{
    "id": "Waiting-10 seconds",
    "name": "Waiting 10 seconds",
    "description": "",
    "line": 1,
    "keyword": "Feature",
    "uri": "C:\\code\\myriad\\myriad-cucumber-js-example\\features\\waiting\\waiting_10_seconds.feature",
    "elements": [{
        "name": "Waiting 10 seconds",
        "id": "Waiting-10 seconds;waiting-10-seconds",
        "line": 4,
        "keyword": "Scenario",
        "description": "",
        "type": "scenario",
        "tags": [{
            "name": "@api",
            "line": 3
        }]
    }]
}]

The bug is in this line of lib/cucumber/listener/json_formatter.js:

currentFeatureId = feature.getName().replace(' ', '-'); // FIXME: wrong abstraction level, this should be encapsulated

Using a regex in the replace would fix it.

currentFeatureId = feature.getName().replace(/ /g, '-'); // FIXME: wrong abstraction level, this should be encapsulated

Do the other ports of cucumber just escape spaces or other characters too?

[jbpros]

Closed by b5bd31a

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.