Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle spaces in dev paths (#1845) #1846

Closed
wants to merge 24 commits into from
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
fb53950
Extract functions into their own files
mattwynne Jul 22, 2021
d9712b1
Allow injection of exclusion filter to make easier to test
mattwynne Jul 23, 2021
8fcb750
Make sure we always exclude ourselves
mattwynne Jul 23, 2021
db95b77
Add unit test for getDefinitionLineAndUri
mattwynne Jul 23, 2021
ed45132
-adds regex pattern for stack traces
eoola Aug 20, 2021
a7750b9
Merge branch 'main' into fix-1735-parens-in-path
eoola Sep 10, 2021
d1217f0
- adds "source-map-support" dependency
eoola Oct 22, 2021
8e462b9
Merge branch 'main' into fix-1735-try-again
eoola Oct 22, 2021
d9c527e
Merge branch 'main' of github.com:cucumber/cucumber-js into fix-1735-…
eoola Nov 1, 2021
fec9841
update cspotcode/source-map-support
eoola Nov 1, 2021
2ce6a34
Merge branch 'main' of github.com:cucumber/cucumber-js into fix-1735-…
eoola Nov 1, 2021
b11b988
remove .DS_Store
eoola Nov 1, 2021
b4203ba
Merge branch 'main' into fix-1735-try-again
mattwynne Nov 2, 2021
827127f
Merge branch 'main' into fix-1735-try-again
mattwynne Nov 5, 2021
1d7a089
updates unit test to support paths on windows
eoola Nov 12, 2021
f6edf13
Merge branch 'fix-1735-try-again' of github.com:eoola/cucumber-js int…
eoola Nov 12, 2021
68cab1e
Removes assertion for a failing test that's no longer needed
eoola Nov 12, 2021
48a7929
Removes exception for the custom stack trace feature
eoola Nov 12, 2021
ea60088
Updates changelog
eoola Nov 12, 2021
9f03c2f
fixed linting for previous commit
eoola Nov 12, 2021
066a0bd
put quotes around the absolute path (#1845)
eoola Nov 19, 2021
cd96f5a
Merge branch 'main' into fix-spaces-in-dev-path
eoola Nov 19, 2021
bf84020
Merge branch 'main' into fix-spaces-in-dev-path
eoola Nov 19, 2021
95f67f1
Merge branch 'fix-spaces-in-dev-path' of github.com:cucumber/cucumber…
eoola Nov 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions features/formatter_paths.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ Feature: Formatter Paths
Background:
Given a file named "features/a.feature" with:
"""
Feature: some feature
Scenario: some scenario
Given a passing step
Feature: some feature
Scenario: some scenario
Given a passing step
"""
And a file named "features/step_definitions/cucumber_steps.js" with:
"""
const {Given} = require('@cucumber/cucumber')
const {Given} = require('@cucumber/cucumber')

Given(/^a passing step$/, function() {})
Given(/^a passing step$/, function() {})
"""

Scenario: Relative path
Expand All @@ -23,9 +23,10 @@ Feature: Formatter Paths
<duration-stat>
"""

@wip
Scenario: Absolute path
Given "{{{tmpDir}}}" is an absolute path
When I run cucumber-js with `-f summary:{{{tmpDir}}}/summary.txt`
When I run cucumber-js with `-f summary:"{{{tmpDir}}}/summary.txt"`
Then the file "{{{tmpDir}}}/summary.txt" has the text:
"""
1 scenario (1 passed)
Expand Down