Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError Console expects a writable stream instance for stdout #2137

Closed
wants to merge 2 commits into from

Conversation

user790235692
Copy link

@user790235692 user790235692 commented Sep 9, 2022

🤔 What's changed?

I add the variable stdout for the parameter of the object console_1 in the file run_cucumber.ts. I made this change to fix TypeError Console expects a writable stream instance for stdout. When I want to run npx nightwatch

⚡️ What's your motivation?

To fix this issue when I want to follow this tutorial

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.236% when pulling 9c2af6a on Twistere:fix/stdout into 01368ca on cucumber:main.

@davidjgoss
Copy link
Contributor

Thanks for taking the time to do this @Twistere! I had a look into the issue and ended up landing what I feel is a more appropriate fix in #2138 - this is now released in 8.5.3 and tested with nightwatch, so you should be good to go there now.

@davidjgoss davidjgoss closed this Sep 10, 2022
@user790235692
Copy link
Author

user790235692 commented Sep 10, 2022

Thanks for taking the time to do this @Twistere! I had a look into the issue and ended up landing what I feel is a more appropriate fix in #2138 - this is now released in 8.5.3 and tested with nightwatch, so you should be good to go there now.

Thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants