Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use explicit status field to determine (not) running status #2386

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Mar 27, 2024

🤔 What's changed?

Update the logic in SupportCodeLibraryBuilder so instead of using a heuristic (absence of cwd) to detect if we are trying to register support code against a non-running install, we have a specific status field that we update along the create/reset/finalize lifecycle.

⚡️ What's your motivation?

In #2353 we are seeing several Windows users reporting this error since 10.0.0 with a configuration that works fine in 9.x.x. This suggests the invalid install error might be a false positive and masking a different issue.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

coverage: 98.387% (+0.002%) from 98.385%
when pulling 66c9bbd on fix/support-code-library-status
into 5a4f129 on main.

@davidjgoss davidjgoss merged commit 23ff64a into main Mar 27, 2024
8 checks passed
@davidjgoss davidjgoss deleted the fix/support-code-library-status branch March 27, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants