Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #2391

Merged
merged 4 commits into from
Apr 21, 2024
Merged

chore: fix typos #2391

merged 4 commits into from
Apr 21, 2024

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Apr 9, 2024

🤔 What's changed?

Fix some typos.

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

  • I hope the change to logUndefinedParameterType is not affecting the users
  • There is ISnippetSnytax which could be changed, but I guess it is a breaking change.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 9, 2024

Coverage Status

coverage: 98.392%. remained the same
when pulling 9c945bb on asashour:typos
into e75764d on cucumber:main.

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, some good spots here.

I hope the change to logUndefinedParameterType is not affecting the users

People do sometimes use these formatters as a base to extend, so on that basis I have reverted this bit because it could be a breaking change.

I've also tweaked one other name where the intent wasn't so obvious.

@davidjgoss davidjgoss merged commit 9dde5d0 into cucumber:main Apr 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants