tool_cb_hdr: allow etag and content-disposition for 3xx reply #13484
+129
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Apr 26, 2024
|
It would be good to also get a test or two for this. |
|
I created two tests for this: 473 and 1487. If you first rebase your branch on a current master, the patches in this tarball should apply fine. |
|
I decided not to try to push these to your branch because I made them against a current master and they did not apply clean on your existing branch and then it quickly got complicated... If you want me to, I can branch off the work in a separate PR with your fix and my tests. |
|
Thanks, I rebased and squashed them in, let's see what happens |
- Parse etag and content-disposition headers for 3xx replies. For example, a server may send a content-disposition filename header with a redirect reply (3xx) but not with the final response (2xx). Without this change curl would ignore the server's specified filename and continue to use the filename extracted from the user-specified URL. Prior to this change, 75d79a4 had limited etag and content-disposition to 2xx replies only. Tests-by: Daniel Stenberg Reported-by: Morgan Willcock Fixes curl#13302 Closes #xxxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, a server may send a content-disposition filename header with a redirect reply (3xx) but not with the final response (2xx). Without this change curl would ignore the server's specified filename and continue to use the filename extracted from the user-specified URL.
Prior to this change, 75d79a4 had limited etag and content-disposition to 2xx replies only.
Reported-by: Morgan Willcock
Fixes #13302
Closes #xxxx