Fix padding(_) #23
Closed
Fix padding(_) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it currently stands, my. padding(_) returns an error of "Cannot read property 'paddingY' of undefined". We doing the chain "my.paddingX(_).paddingY(_)"; however, "paddingX(_)" does not actually return anything like Left/Right/Top/Bottom does, and "paddingY(_)" cannot be called on undefined. My proposed solution is to separate "my.paddingX(_).paddingY(_)" into two separate calls "my.paddingX(_)" and "my.paddingY(_)".
curran
requested changes
Jul 15, 2019
There was a problem hiding this comment.
I understand the problem you've described. However, I think a better solution would be to have everything return my, instead of this change you suggest, which feels more like a workaround (treating the symptom, not the disease).
I suggest you modify this PR such that the following methods return my:
my.paddingX = function(_) {
my.paddingLeft(_).paddingRight(_);
};
my.paddingY = function(_) {
my.paddingTop(_).paddingBottom(_);
};
my.padding = function(_) {
my.paddingX(_).paddingY(_);
};Like this:
my.paddingX = function(_) {
return my.paddingLeft(_).paddingRight(_);
};
my.paddingY = function(_) {
return my.paddingTop(_).paddingBottom(_);
};
my.padding = function(_) {
return my.paddingX(_).paddingY(_);
};I think that should work..
Thank you for your effort here!
| @@ -242,7 +242,8 @@ function areaLabel(area) { | |||
| }; | |||
|
|
|||
| my.padding = function(_) { | |||
| my.paddingX(_).paddingY(_); | |||
| my.paddingX(_) | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands, my. padding(_) returns an error of "Cannot read property 'paddingY' of undefined".
my.padding() does the chain "my.paddingX().paddingY()"; however, "paddingX()" does not actually return anything like Left/Right/Top/Bottom does, and "paddingY(_)" cannot be called on undefined.
My proposed solution is to separate "my.paddingX().paddingY()" into two separate calls "my.paddingX()" and "my.paddingY()".