refactor: use count(*) for better performance when possible

cycle · Dec 6, 2021 · b7ea9a9 · b7ea9a9
1 parent e680b3f
commit b7ea9a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/Select/RootLoader.php b/src/Select/RootLoader.php
@@ -92,11 +92,10 @@ public function getPK(): string
     public function getCountField(): string
     {
         if ($this->isDataDuplicationPossible()) {
-            // @tuneyourserver solves the issue with counting on queries with joins.
             return sprintf('DISTINCT(%s)', $this->getPK());
         }
 
-        return $this->getPK();
+        return '*';
     }
 
     /**

diff --git a/tests/ORM/SelectorTest.php b/tests/ORM/SelectorTest.php
@@ -218,9 +218,9 @@ public function testCountField(): void
         $pk = \sprintf('%s.%s', $role, 'id');
         $distinct = \sprintf('DISTINCT(%s)', $pk);
 
-        $this->assertSame($pk, (new RootLoader($this->orm, $role))->getCountField());
-        $this->assertSame($pk, $this->joinRelation(new RootLoader($this->orm, $role), 'profile')->getCountField());
-        $this->assertSame($pk, $this->joinRelation(new RootLoader($this->orm, $role), 'lastComment', [
+        $this->assertSame('*', (new RootLoader($this->orm, $role))->getCountField());
+        $this->assertSame('*', $this->joinRelation(new RootLoader($this->orm, $role), 'profile')->getCountField());
+        $this->assertSame('*', $this->joinRelation(new RootLoader($this->orm, $role), 'lastComment', [
             'method' => Select\AbstractLoader::LEFT_JOIN,
         ])->getCountField());
         $this->assertSame(