Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: fix colorama upper pin #6158

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

oliver-sanders
Copy link
Member

Spotted during release, the colorama dependency has a strange upper pin.

This goes right back to before the setup.cfg file (8b510ab).

Change this to match the correct value in the conda-environment.yml file.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Jun 19, 2024
@oliver-sanders oliver-sanders self-assigned this Jun 19, 2024
@MetRonnie
Copy link
Member

Should this in 8.3.x?

@oliver-sanders oliver-sanders changed the base branch from master to 8.3.x June 19, 2024 14:41
@oliver-sanders
Copy link
Member Author

Yes, may as well, rebased.

@MetRonnie MetRonnie modified the milestones: 8.4.0, 8.3.1 Jun 19, 2024
@MetRonnie

This comment was marked as resolved.

@MetRonnie MetRonnie merged commit 61c1f28 into cylc:8.3.x Jun 19, 2024
28 of 35 checks passed
@oliver-sanders oliver-sanders deleted the colorama-pin branch June 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants