Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates to CI and the CI Examples #580

Merged
merged 6 commits into from
Dec 6, 2022
Merged

chore: updates to CI and the CI Examples #580

merged 6 commits into from
Dec 6, 2022

Conversation

emilyrohrbough
Copy link
Member

  • Update CI pipelines & fix errors & hopefully the automatic release when merged to master
  • Update CI examples to show pulling the latest node versions/images vs node which is now deprecated
  • Bump the project's node version to 14

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2022

CLA assistant check
All committers have signed the CLA.

@cypress
Copy link

cypress bot commented Dec 6, 2022



Test summary

122 0 0 0


Run details

Project cypress-example-kitchensink
Status Passed
Commit 9d2d5a2
Started Dec 6, 2022 9:36 PM
Ended Dec 6, 2022 9:42 PM
Duration 06:07 💡
OS Windows 10.0.17763
Browser Edge 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@@ -9,13 +9,13 @@ jobs:
# Job names can contain alphanumeric characters and '_', cannot start with a number
- job: Cypress_e2e_tests
pool:
vmImage: 'ubuntu-16.04'
vmImage: 'ubuntu-latest'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per actions/runner-images#3287:

Traditional 5-years support of Ubuntu 16.04 by Canonical ends in April, 2021. To keep our environment updated and secured, we will remove Ubuntu 16.04 from GitHub on September 20, 2021, and from Azure DevOps on October 18, 2021.

This failed to run: https://cypress-io.visualstudio.com/cypress-example-kitchensink/_build/results?buildId=1642&view=logs&j=d2f18934-c168-59e0-ad20-3282681c6565

@@ -2,7 +2,7 @@ version: 2
jobs:
test:
docker:
- image: cypress/base:10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.

@@ -13,7 +13,7 @@ cache:
- cache/Cypress

test:
image: cypress/base:10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.

@@ -20,7 +20,7 @@ blocks:
jobs:
- name: npm ci and cache
commands:
- nvm install 12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to use the latest LTS node version.

@@ -1,8 +1,7 @@
language: node_js

node_js:
# Node 10.3+ includes npm@6 which has good "npm ci" command
- 10.8
- 18
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to use the latest LTS node version.

@@ -9,7 +9,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: '12.x'
versionSpec: '18.x'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to use the latest LTS node version.

@@ -2,7 +2,7 @@
# https://documentation.codeship.com/pro/languages-frameworks/nodejs/

# use Cypress provided image with all dependencies included
FROM cypress/base:10
FROM cypress/base:latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.

@@ -2,7 +2,7 @@ pipeline {
agent {
// this image provides everything needed to run Cypress
docker {
image 'cypress/base:10'
image 'cypress/base:latest'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress v12 dropped node 12 support. This is an example for users. Updated to pull latest.

@@ -77,7 +76,7 @@
"yaml-lint": "1.2.4"
},
"engines": {
"node": ">=12"
"node": "^14.0.0 || ^16.0.0 || >=18.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match Cypress's node engines.

@cypress
Copy link

cypress bot commented Dec 6, 2022



Test summary

122 0 0 0


Run details

Project cypress-example-kitchensink
Status Passed
Commit 522a90e ℹ️
Started Dec 6, 2022 9:39 PM
Ended Dec 6, 2022 9:45 PM
Duration 06:10 💡
OS Windows 10.0.17763
Browser Edge 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@@ -60,9 +60,8 @@
},
"devDependencies": {
"@bahmutov/print-env": "1.2.0",
"@cypress/eslint-plugin-dev": "5.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had peer dependencies on eslint-plugin-mocha v4, which wanted eslint v4. To keep the newer version of eslint, removed @cypress/eslint-plugin-dev

@emilyrohrbough emilyrohrbough changed the title Updates to CI and Examples chore: updates to CI and the CI Examples Dec 6, 2022
@emilyrohrbough
Copy link
Member Author

The base build image needs updated for the cypress-example-kitchensink project in netlify. The is currently is Ubuntu 16.04 Xenial Xerus which has been removed so the site is unable to deploy. It needs to be updated to Ubuntu Focal 20.04.

I don’t have access to the project settings to bump this myself. Have reached out to have this resolved by somone with access.

@emilyrohrbough emilyrohrbough marked this pull request as ready for review December 6, 2022 21:46
@emilyrohrbough emilyrohrbough merged commit b3aaa56 into master Dec 6, 2022
@emilyrohrbough emilyrohrbough deleted the fix-ci branch December 6, 2022 22:10
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants